Add BF16 output support for inference TBE #1498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 8, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 153ac1698c60fb4ee55a2f67fed88b204dd67c2f
jianyuh
force-pushed
the
export-D41835847
branch
from
297d2bd to
15bfbfb
Compare
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 8, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 8c73f194fb4af50a1ea044502b166f72ba8fe729
jianyuh
force-pushed
the
export-D41835847
branch
from
15bfbfb to
d945d91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: a82c1c71fa6330bd8839c1e2db2e9e1d40851bef
jianyuh
force-pushed
the
export-D41835847
branch
from
d945d91 to
e6c7708
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 8390547edff54c743ce628a75937bd77ba1c0966
jianyuh
force-pushed
the
export-D41835847
branch
from
e6c7708 to
9d4ca18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 8833f998297cf7e11f6439d9974120fcf33bd7c0
jianyuh
force-pushed
the
export-D41835847
branch
from
9d4ca18 to
26a6889
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 871c23f27027d8478372342181db3e1ba53c7cdf
jianyuh
force-pushed
the
export-D41835847
branch
from
26a6889 to
7c09c56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
commented
Dec 11, 2022
| @@ -21,6 +21,7 @@ | |||
| // clang-format on | |||
|
|
|||
| #include <cuda.h> | |||
| #include <cuda_bf16.h> | |||
There was a problem hiding this comment.
@shintaro-iwasaki / @liligwu Do you have the suggestion on how to enable HIP support for cuda_bf16.h ? Looks like HIP tests are failing with the include of this header file: https://github.com/pytorch/FBGEMM/actions/runs/3654785378/jobs/6175505771
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 11, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 5e0dda99042dd65940ca98a8f24d9ab06ff46338
jianyuh
force-pushed
the
export-D41835847
branch
from
7c09c56 to
8b30ac8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 11, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 141ab6fb5cc2ccdd40e83ab24404f14e16dfb96f
jianyuh
force-pushed
the
export-D41835847
branch
from
8b30ac8 to
0d908ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 11, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: ddd473934b8a2de95e954e35f9610ab3595877d9
jianyuh
force-pushed
the
export-D41835847
branch
from
0d908ab to
4092cd3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Dec 12, 2022
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 90eca696aa33c6a54962f9bb0f525e1f98ec8dea
jianyuh
force-pushed
the
export-D41835847
branch
from
4092cd3 to
2ae93b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
Summary: Pull Request resolved: pytorch#1498 As title Reviewed By: jiecaoyu Differential Revision: D41835847 fbshipit-source-id: 24c09f3b146d7cc70194d73a639cc07a5c7e944d
|
This pull request was exported from Phabricator. Differential Revision: D41835847 |
jianyuh
force-pushed
the
export-D41835847
branch
from
2ae93b7 to
ae176d2
Compare
|
This pull request has been merged in 39a423e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title
Reviewed By: jiecaoyu
Differential Revision: D41835847