-
Notifications
You must be signed in to change notification settings - Fork 610
[T145005253] Fix the build scripts infrastructure #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
0da05e7
to
d70cb2d
Compare
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d70cb2d
to
bca01b0
Compare
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
95b5cbd
to
02589cb
Compare
…tions - Add well-defined functions to `.github/scripts/setup_env.bash` to handle individual steps in FBGEMM_GPU installation - Update existing scripts to call the functions in `.github/scripts/setup_env.bash` as part of execution
- Update the FBGEMM_GPU nightly publish jobs to use functions in `.github/scripts/setup_env.bash` - Add new script function to install C/C++ compilers properly through Conda or Yum
- Updates to `.github/scripts/setup_env.bash` to improve the reliability of the functions - Update GitHub action references to v3 - Update FBGEMMCI / build_nvidia_gpu job to use the functions defined in `.github/scripts/setup_env.bash`
- Split up FBGEMMCI job definitions into `.github/workflows/fbgemm_ci.yml` and `.github/workflows/fbgemm_gpu_ci.yml` - Rename the jobs to be less confusing
- Set the nightly builds to use larger instances for more build parallelization - Disable the failing jobs in FBGEMM_GPU CI - Remove support for building against CUDA 11.5 and 11.6 - Disable the actual Publish-to-PyPI step from the nightly build jobs when run in PR or Push mode - Disable the cron trigger on push_trigger_wheel jobs
727f3ce
to
c9bef9b
Compare
30a3e57
to
f7f3afe
Compare
- Remove commented code - Clean up the scripts to be compliant with shellcheck linting
f7f3afe
to
b529d25
Compare
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
setup_env.bash