Skip to content

Create separate targets for training and inference #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented May 10, 2023

Summary:

  • Create separate targets for training and inference

  • Redefine the old embedding_ops and embedding_ops as an empty
    target with exported_defs pointing to the new split targets

Differential Revision: D45687293

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit 472b889
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/64655668e0ae4c00070eda9e

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: ef82e9eda4feee70914680e62ef9dc3fd780421d
@q10 q10 force-pushed the export-D45687293 branch from 5e684ff to 2a1c68f Compare May 11, 2023 01:16
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: bc14b40d910daf4352208db2581dcaefef580796
@q10 q10 force-pushed the export-D45687293 branch from 2a1c68f to 8ca85e0 Compare May 11, 2023 04:55
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 1d272ff371b28c66c7d595a30bc8285d236a6839
@q10 q10 force-pushed the export-D45687293 branch from 8ca85e0 to 880b951 Compare May 11, 2023 05:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 0d8f413a5e3604474c23b1750d9f814b58c1bfda
@q10 q10 force-pushed the export-D45687293 branch from 880b951 to 18495c3 Compare May 11, 2023 05:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 151a36ea891e7fc209ad30f3daaac68ace254f2e
@q10 q10 force-pushed the export-D45687293 branch from 18495c3 to 3c81f11 Compare May 11, 2023 05:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 833f9729f7b8a2cfa0125303670c1f95de634088
@q10 q10 force-pushed the export-D45687293 branch from 3c81f11 to 67f9040 Compare May 11, 2023 05:18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: fc92909a4700a7ac5da5495dcbe4ab18ca6905a9
@q10 q10 force-pushed the export-D45687293 branch from 67f9040 to 2c25f32 Compare May 11, 2023 06:18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 62dd4d6af9c8f7c1b168fa5007dbcdd07ee4786c
@q10 q10 force-pushed the export-D45687293 branch from 2c25f32 to 219f778 Compare May 11, 2023 06:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 3bb7d0dd95211a2ae464528a5714e2bbe041cffe
@q10 q10 force-pushed the export-D45687293 branch from 219f778 to abfce26 Compare May 11, 2023 07:33
@q10 q10 force-pushed the export-D45687293 branch from 5deeccb to 15c36e0 Compare May 16, 2023 22:15
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: bd900353d06adb87d5f05d5791b14aa908b352f1
@q10 q10 force-pushed the export-D45687293 branch from 15c36e0 to 0b7a64b Compare May 17, 2023 01:41
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 8b5f2d9452933dfa069ffdaf00c846b058dade3c
@q10 q10 force-pushed the export-D45687293 branch from 0b7a64b to ce34058 Compare May 17, 2023 01:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: 838d8e4841ba44f8264f9f1d2d17f31832a352d0
@q10 q10 force-pushed the export-D45687293 branch from ce34058 to bfe549e Compare May 17, 2023 20:04
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Differential Revision: D45687293

fbshipit-source-id: a40735c94362f2761a0ddd699252ad22323d8d57
@q10 q10 force-pushed the export-D45687293 branch from bfe549e to 402a45b Compare May 17, 2023 20:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Reviewed By: sryap

Differential Revision: D45687293

fbshipit-source-id: 7cfbaa862f17fba845f2462b7cb313ed62a65794
@q10 q10 force-pushed the export-D45687293 branch from 402a45b to e19dc8e Compare May 17, 2023 21:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Reviewed By: sryap

Differential Revision: D45687293

fbshipit-source-id: f0f428330d945e4da7efcebba891812048275153
@q10 q10 force-pushed the export-D45687293 branch from e19dc8e to dde0a38 Compare May 17, 2023 22:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

q10 added a commit to q10/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Reviewed By: sryap

Differential Revision: D45687293

fbshipit-source-id: 9907225a3b557916dd11caccb2612528cca234a4
@q10 q10 force-pushed the export-D45687293 branch from dde0a38 to 5ec6dc6 Compare May 17, 2023 22:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

Summary:
Pull Request resolved: pytorch#1757

- Create separate targets for training and inference

- Redefine the old `embedding_ops` and `embedding_ops` as an empty
target with `exported_defs` pointing to the new split targets

Reviewed By: sryap

Differential Revision: D45687293

fbshipit-source-id: 1d163ae701de386fad8cb2c0066c499844701f72
@q10 q10 force-pushed the export-D45687293 branch from 5ec6dc6 to 472b889 Compare May 17, 2023 22:34
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45687293

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2ae07d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants