Skip to content

Symbolic shape tracing on jagged op #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xw285cornell
Copy link
Contributor

Summary: fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit 17006f4
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/646431a275d33a0008a77994

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 21bd9588e31d392259704e04d98607b76ba551ab
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 2de320d5a1e62cd47ce52d58e22f8dd677ef088a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: a8dec94d6fe251ff49dcbed560122c8309fb4484
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: b7ed2e2f8d3fa20adafebc290eab2de79992f3f6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: c7d37d99aea8d9dfbd09f6b54d7519ebaffa65d5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 949b20f6f8e830c8691473c6441d888f00224ffc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 16, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 63729c17e826d943a0dde59630e65dcf636499c5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

xw285cornell added a commit to xw285cornell/FBGEMM that referenced this pull request May 17, 2023
Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 6ac8ad9ba79b24b9f63449f9cb076337e21def8f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

Summary:
Pull Request resolved: pytorch#1758

fbgemm's jagged op doesn't have symint support in the meta function, resulting in all the shapes specialized (materialized int baked in the model instead of symbolic shape). Fixing them.

Differential Revision:
D44736488

Privacy Context Container: L1156430

fbshipit-source-id: 2273fc287f31992e8291b55ccd517696ec4230db
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44736488

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0a3380f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants