Support variable bucket size for block_bucketize_sparse_features #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 1, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
1431010 to
bc941fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 1, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
bc941fc to
772a8c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
force-pushed
the
export-D50868649
branch
from
772a8c6 to
fb684f6
Compare
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 7, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 7, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
fb684f6 to
0396b20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
force-pushed
the
export-D50868649
branch
from
0396b20 to
50eeead
Compare
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 14, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 14, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
50eeead to
b53452f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 14, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
b53452f to
e0f50e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 14, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
e0f50e1 to
5fb5a07
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 14, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
5fb5a07 to
3020a0c
Compare
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
e0f50e1 to
5487f90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
5487f90 to
6d82951
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
6d82951 to
8b33e80
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
8b33e80 to
e762d10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
e762d10 to
a76a019
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
force-pushed
the
export-D50868649
branch
from
a76a019 to
8b33e80
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Reviewed By: jiayisuse Differential Revision: D50868649
tissue3
added a commit
to tissue3/FBGEMM
that referenced
this pull request
Nov 15, 2023
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Reviewed By: jiayisuse Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
8b33e80 to
8b1c258
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
…orch#2107) Summary: This diff add support for variable bucket size for block bucketize_sparse features for RW sharding. E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]] For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1. For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1. The new index will be original index - bucket_sizes_pos[new_bucket_id-1] i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7. Reviewed By: jiayisuse Differential Revision: D50868649
tissue3
force-pushed
the
export-D50868649
branch
from
8b1c258 to
405df97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50868649 |
|
This pull request has been merged in 2eb3eb4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff add support for variable bucket size for block bucketize_sparse features for RW sharding.
E.g. Given bucket_sizes_pos as [[0,5,15], [0,10,13]]
For batch 0, indices in [0,5) will be assigned to bucket 0, indices in [5,15) will be assigned to bucket 1.
For batch 1, indices in [0,10) will be assigned to bucket 0, indices in [10,13) will be assigned to bucket 1.
The new index will be original index - bucket_sizes_pos[new_bucket_id-1]
i.e. for batch = 0, index = 12, it will be assigned to bucket 1 and the new index is 12 - 5 = 7.
Differential Revision: D50868649