remove symint from tbe_input_combine_with_length_abstract #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D53862184 |
bradleyhd
force-pushed
the
export-D53862184
branch
from
af8bddc to
95d728d
Compare
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53862184 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
khabinov
approved these changes
Feb 16, 2024
|
This pull request was exported from Phabricator. Differential Revision: D53862184 |
Summary: as titled, the number of offsets is not dynamic, rather it is the sum of the number of elements in the concatenated offset tensors additionally, make sure new tensors are created on the same device as the indices Reviewed By: khabinov Differential Revision: D53862184
bradleyhd
force-pushed
the
export-D53862184
branch
from
95d728d to
95d504f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53862184 |
|
This pull request has been merged in bc4a73e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
as titled, the number of offsets is not dynamic, rather it is the sum of the number of elements in the concatenated offset tensors
additionally, make sure new tensors are created on the same device as the indices
Differential Revision: D53862184