Build hip rules by default #2380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54439410 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Mar 5, 2024
Summary: Moving the HIP rules out so that we build by default. Reviewed By: jianyuh Differential Revision: D54439410
xw285cornell
force-pushed
the
export-D54439410
branch
from
ac9a70f to
95c422a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54439410 |
Summary: Pull Request resolved: pytorch#2380 Moving the HIP rules out so that we build by default. Reviewed By: jianyuh Differential Revision: D54439410
|
This pull request was exported from Phabricator. Differential Revision: D54439410 |
xw285cornell
force-pushed
the
export-D54439410
branch
from
95c422a to
a25b8be
Compare
|
This pull request has been merged in 57e0a6b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Moving the HIP rules out so that we build by default.
Reviewed By: jianyuh
Differential Revision: D54439410