Skip to content

[fbgemm_gpu] Re-organize the setup.py script #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Mar 13, 2024

  • Re-organize the setup.py script to handle release versioning for Nova
  • Unconditionally install Miniconda and override existing installations

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 8ef380a
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/65f2296f1a783700081826c5
😎 Deploy Preview https://deploy-preview-2423--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the bm/upgrade-setup-scripts branch 2 times, most recently from 6840247 to 1d1ef39 Compare March 13, 2024 17:51
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 changed the title [fbgemm_gpu] Upgrade setup.py script [fbgemm_gpu] Re-organize the setup.py script Mar 13, 2024
@q10 q10 force-pushed the bm/upgrade-setup-scripts branch from 1d1ef39 to 8a1ae25 Compare March 13, 2024 18:34
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

- Re-organize the `setup.py` script to handle release versioning for Nova

- Unconditionally install Miniconda and override existing installations
@q10 q10 force-pushed the bm/upgrade-setup-scripts branch from 8a1ae25 to 8ef380a Compare March 13, 2024 22:32
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in 60416ee.

q10 added a commit that referenced this pull request Mar 15, 2024
Summary:
- Re-organize the `setup.py` script to handle release versioning for Nova
- Unconditionally install Miniconda and override existing installations

Pull Request resolved: #2423

Reviewed By: spcyppt

Differential Revision: D54861100

Pulled By: q10

fbshipit-source-id: 65f89339a924db0383d0f4330ce8e5cdeedbfc26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants