pass in kernel tbe id into rocksdb wrapper #2930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D60635718 |
duduyi2013
force-pushed
the
export-D60635718
branch
from
e843481 to
dda9d7e
Compare
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Aug 3, 2024
Summary: X-link: facebookresearch/FBGEMM#32 Pull Request resolved: pytorch#2930 the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host. This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port. Reviewed By: sryap Differential Revision: D60635718
|
This pull request was exported from Phabricator. Differential Revision: D60635718 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60635718 |
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Aug 3, 2024
Summary: X-link: facebookresearch/FBGEMM#32 Pull Request resolved: pytorch#2930 the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host. This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port. Reviewed By: sryap Differential Revision: D60635718
duduyi2013
force-pushed
the
export-D60635718
branch
from
dda9d7e to
c2f948d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60635718 |
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Aug 4, 2024
Summary: X-link: facebookresearch/FBGEMM#32 Pull Request resolved: pytorch#2930 the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host. This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port. Reviewed By: sryap Differential Revision: D60635718
duduyi2013
force-pushed
the
export-D60635718
branch
from
c2f948d to
c7c1971
Compare
Summary: X-link: facebookresearch/FBGEMM#32 Pull Request resolved: pytorch#2930 the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host. This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port. Reviewed By: sryap Differential Revision: D60635718
|
This pull request was exported from Phabricator. Differential Revision: D60635718 |
duduyi2013
force-pushed
the
export-D60635718
branch
from
c7c1971 to
639a2f7
Compare
|
This pull request has been merged in 6607072. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#32 X-link: pytorch#2930 the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host. This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port. Reviewed By: sryap Differential Revision: D60635718 fbshipit-source-id: 606216a4a2d5a43f82f7bd681477537413bd372a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
the reason we need this is we constantly see the port conflict error in rocksdb initialization. Before this diff we call getFreePort to ge an available port. For each ssd tbe we will create 32 rocksdb shards, so in total there are 256 ports needed per host.
This works fine with 4 hosts until we are running 16 hosts training job as we need make sure all 16 hosts don't get into the corner cases where multiple db shard get assigned the same free port.
Differential Revision: D60635718