Integrate l2 cache to TBE operator #2959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D60289936 |
|
This pull request was exported from Phabricator. Differential Revision: D60289936 |
jma99fb
added a commit
to jma99fb/FBGEMM
that referenced
this pull request
Aug 9, 2024
Summary: Pull Request resolved: pytorch#2959 Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff 1. Implements the CacheLib based L2 cache class as a wrapper to provide a unified interface including get() and put() from/to CPU caches. 2. Integrates the L2 cache class into the EmbedingKVDB base class to expand the capability of the get()/set() functions. 3. Introduces the async get()/set() APIs for PS/SSD for performance tuning reason (e.g. enabled the parallelism to the memcpy and get from remote storage) Reviewed By: sryap Differential Revision: D60289936
jma99fb
force-pushed
the
export-D60289936
branch
from
7927498 to
a31dcf1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60289936 |
jma99fb
added a commit
to jma99fb/FBGEMM
that referenced
this pull request
Aug 9, 2024
Summary: X-link: facebookresearch/FBGEMM#61 Pull Request resolved: pytorch#2959 Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff 1. Implements the CacheLib based L2 cache class as a wrapper to provide a unified interface including get() and put() from/to CPU caches. 2. Integrates the L2 cache class into the EmbedingKVDB base class to expand the capability of the get()/set() functions. 3. Introduces the async get()/set() APIs for PS/SSD for performance tuning reason (e.g. enabled the parallelism to the memcpy and get from remote storage) Reviewed By: sryap Differential Revision: D60289936
jma99fb
force-pushed
the
export-D60289936
branch
from
a31dcf1 to
a250477
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60289936 |
jma99fb
added a commit
to jma99fb/FBGEMM
that referenced
this pull request
Aug 9, 2024
Summary: X-link: facebookresearch/FBGEMM#61 Pull Request resolved: pytorch#2959 Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff 1. Implements the CacheLib based L2 cache class as a wrapper to provide a unified interface including get() and put() from/to CPU caches. 2. Integrates the L2 cache class into the EmbedingKVDB base class to expand the capability of the get()/set() functions. 3. Introduces the async get()/set() APIs for PS/SSD for performance tuning reason (e.g. enabled the parallelism to the memcpy and get from remote storage) Reviewed By: sryap Differential Revision: D60289936
jma99fb
force-pushed
the
export-D60289936
branch
from
a250477 to
1e3b57b
Compare
Summary: X-link: facebookresearch/FBGEMM#61 Pull Request resolved: pytorch#2959 Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff 1. Implements the CacheLib based L2 cache class as a wrapper to provide a unified interface including get() and put() from/to CPU caches. 2. Integrates the L2 cache class into the EmbedingKVDB base class to expand the capability of the get()/set() functions. 3. Introduces the async get()/set() APIs for PS/SSD for performance tuning reason (e.g. enabled the parallelism to the memcpy and get from remote storage) Reviewed By: sryap Differential Revision: D60289936
|
This pull request was exported from Phabricator. Differential Revision: D60289936 |
jma99fb
force-pushed
the
export-D60289936
branch
from
1e3b57b to
16816ed
Compare
|
This pull request has been merged in 9987dba. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#61 X-link: pytorch#2959 Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff 1. Implements the CacheLib based L2 cache class as a wrapper to provide a unified interface including get() and put() from/to CPU caches. 2. Integrates the L2 cache class into the EmbedingKVDB base class to expand the capability of the get()/set() functions. 3. Introduces the async get()/set() APIs for PS/SSD for performance tuning reason (e.g. enabled the parallelism to the memcpy and get from remote storage) Reviewed By: sryap Differential Revision: D60289936 fbshipit-source-id: 4a33c534aa7a75c38d7d81dbf4872ecfe120cec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Integrate the CacheLib based L2 cache into TBE operator. At a high level, this diff
Differential Revision: D60289936