support rope with block tables #3146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61898380 |
|
This pull request was exported from Phabricator. Differential Revision: D61898380 |
SungMinCho
added a commit
to SungMinCho/FBGEMM
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: pytorch#3146 X-link: facebookresearch/FBGEMM#227 Modify `rope_xpos_qkv_varseq_prefill_kernel_` so that it uses page indirection for qparam tensors as well. Reviewed By: sgrigory Differential Revision: D61898380
SungMinCho
force-pushed
the
export-D61898380
branch
from
05b2fa7 to
8bfa07c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61898380 |
SungMinCho
added a commit
to SungMinCho/FBGEMM
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: pytorch#3146 X-link: facebookresearch/FBGEMM#227 Modify `rope_xpos_qkv_varseq_prefill_kernel_` so that it uses page indirection for qparam tensors as well. Reviewed By: sgrigory Differential Revision: D61898380
SungMinCho
force-pushed
the
export-D61898380
branch
from
8bfa07c to
3f3151e
Compare
Summary: Pull Request resolved: pytorch#3146 X-link: facebookresearch/FBGEMM#227 Modify `rope_xpos_qkv_varseq_prefill_kernel_` so that it uses page indirection for qparam tensors as well. Reviewed By: sgrigory Differential Revision: D61898380
|
This pull request was exported from Phabricator. Differential Revision: D61898380 |
SungMinCho
force-pushed
the
export-D61898380
branch
from
3f3151e to
22a833a
Compare
|
This pull request has been merged in d64d1f6. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3146 Pull Request resolved: facebookresearch/FBGEMM#227 Modify `rope_xpos_qkv_varseq_prefill_kernel_` so that it uses page indirection for qparam tensors as well. Reviewed By: sgrigory Differential Revision: D61898380 fbshipit-source-id: fa8b9a3dc42333358ee056bfb793b72bf7d7e450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/227
Modify
rope_xpos_qkv_varseq_prefill_kernel_so that it uses page indirection for qparam tensors as well.Reviewed By: sgrigory
Differential Revision: D61898380