make iter PT2 compatible
#3253
Closed
make iter PT2 compatible
#3253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use `int` and dynamic condition is not compatible with PT2 compile. Fixing it by using a cpu tensor and sync at the first forward. Need to wrap it with `is_torchdynamo_compiling`, PT2 happens at 3rd iteration according to Microve Differential Revision: D64510142
|
This pull request was exported from Phabricator. Differential Revision: D64510142 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 25cff5c. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3253 Pull Request resolved: facebookresearch/FBGEMM#353 Use `int` and dynamic condition is not compatible with PT2 compile. Fixing it by using a cpu tensor and sync at the first forward. Need to wrap it with `is_torchdynamo_compiling`, PT2 happens at 3rd iteration according to Microve Reviewed By: Microve Differential Revision: D64510142 fbshipit-source-id: 5ba866b258df2d3d1d6555653993de59ba9110cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use
intand dynamic condition is not compatible with PT2 compile. Fixing it by using a cpu tensor and sync at the first forward. Need to wrap it withis_torchdynamo_compiling, PT2 happens at 3rd iteration according to MicroveDifferential Revision: D64510142