Reduce registers in bounds_check_indices #3298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D65071179 |
Summary: X-link: facebookresearch/FBGEMM#397 Reduce the number of registers per thread in `bounds_check_indices` to increase occupancy by: - Passing `bounds_check_mode` as a kernel template arg - Moving `printf` for indices checking outside of the for-loop for `BoundsCheckMode::WARNING` - Moving the last offset check outside of the for-loop Reviewed By: q10, Fiery Differential Revision: D65071179
sryap
force-pushed
the
export-D65071179
branch
from
35b02b6 to
143ac0d
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Nov 1, 2024
Summary: X-link: facebookresearch/FBGEMM#397 Reduce the number of registers per thread in `bounds_check_indices` to increase occupancy by: - Passing `bounds_check_mode` as a kernel template arg - Moving `printf` for indices checking outside of the for-loop for `BoundsCheckMode::WARNING` - Moving the last offset check outside of the for-loop Reviewed By: q10, Fiery Differential Revision: D65071179
|
This pull request was exported from Phabricator. Differential Revision: D65071179 |
|
This pull request has been merged in 21e86af. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#397 X-link: pytorch#3298 Reduce the number of registers per thread in `bounds_check_indices` to increase occupancy by: - Passing `bounds_check_mode` as a kernel template arg - Moving `printf` for indices checking outside of the for-loop for `BoundsCheckMode::WARNING` - Moving the last offset check outside of the for-loop Reviewed By: q10, Fiery Differential Revision: D65071179 fbshipit-source-id: 6185ff35dac6cbf50fb2c7ec172ac82ed3b0c746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reduce the number of registers per thread in
bounds_check_indicestoincrease occupancy by:
bounds_check_modeas a kernel template argprintffor indices checking outside of the for-loop forBoundsCheckMode::WARNINGDifferential Revision: D65071179