make L2/rocksdb update async optional #3429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D66550003 |
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Dec 2, 2024
Summary: X-link: facebookresearch/FBGEMM#516 changeset 1. make L2/rocksdb async update optional 2. update assertion into check, since assert doesn't work 3. adjust locking mechanism Differential Revision: D66550003
Summary: X-link: facebookresearch/FBGEMM#516 changeset 1. make L2/rocksdb async update optional 2. update assertion into check, since assert doesn't work 3. adjust locking mechanism Reviewed By: chrisxcai Differential Revision: D66550003
duduyi2013
force-pushed
the
export-D66550003
branch
from
740f30c to
7211982
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66550003 |
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Dec 3, 2024
Summary: X-link: facebookresearch/FBGEMM#516 changeset 1. make L2/rocksdb async update optional 2. update assertion into check, since assert doesn't work 3. adjust locking mechanism Reviewed By: chrisxcai Differential Revision: D66550003
|
This pull request has been merged in 8f6dcee. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3429 Pull Request resolved: facebookresearch/FBGEMM#516 changeset 1. make L2/rocksdb async update optional 2. update assertion into check, since assert doesn't work 3. adjust locking mechanism Reviewed By: chrisxcai Differential Revision: D66550003 fbshipit-source-id: 98361dc05a3618dc487fda946541381ae4215d8f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changeset
Differential Revision: D66550003