Reland of D65489998 Optimize sharding performance of embeddings" #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff is a reland of D65489998 after backout in D66800554. Reviewed By: iamzainhuda Differential Revision: D66828907
|
This pull request was exported from Phabricator. Differential Revision: D66828907 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iamzainhuda
pushed a commit
to iamzainhuda/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: X-link: pytorch/FBGEMM#3549 X-link: facebookresearch/FBGEMM#634 This diff is a reland of D65489998 after backout in D66800554. Reviewed By: iamzainhuda Differential Revision: D66828907
iamzainhuda
pushed a commit
to iamzainhuda/torchrec
that referenced
this pull request
Jan 6, 2025
…orch#2664) Summary: X-link: pytorch/FBGEMM#3549 X-link: facebookresearch/FBGEMM#634 This diff is a reland of D65489998 after backout in D66800554. Reviewed By: iamzainhuda Differential Revision: D66828907
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: Pull Request resolved: #2664 X-link: pytorch/FBGEMM#3549 X-link: facebookresearch/FBGEMM#634 This diff is a reland of D65489998 after backout in D66800554. Reviewed By: iamzainhuda Differential Revision: D66828907 fbshipit-source-id: ab6e6a9faa8255c4847a69a8efb46182bedc9737
|
This pull request has been merged in b24fde5. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
…orch#634) Summary: X-link: pytorch/torchrec#2664 X-link: pytorch#3549 Pull Request resolved: facebookresearch/FBGEMM#634 This diff is a reland of D65489998 after backout in D66800554. Reviewed By: iamzainhuda Differential Revision: D66828907 fbshipit-source-id: ab6e6a9faa8255c4847a69a8efb46182bedc9737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff is a reland of D65489998 after backout in D66800554.
Reviewed By: iamzainhuda
Differential Revision: D66828907