Skip to content

Add support for int32_t indices in TBE training (2I/N) #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Jan 7, 2025

Summary: - Add int21_t support to ::internal::csr2csc, for eventual int32_t indices support in TBE CPU

Reviewed By: jianyuh

Differential Revision: D67920539

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67920539

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 9cc6db5
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67901aac1610ef000804d990
😎 Deploy Preview https://deploy-preview-3556--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
Summary:

- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@q10 q10 force-pushed the export-D67920539 branch from 587a513 to ef5ad9f Compare January 9, 2025 22:22
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
Summary:

- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67920539

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
Summary:

- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@q10 q10 force-pushed the export-D67920539 branch from ef5ad9f to 743d0da Compare January 10, 2025 22:35
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67920539

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@q10 q10 force-pushed the export-D67920539 branch from 743d0da to ed1f69b Compare January 14, 2025 19:23
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67920539

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added 2 commits January 21, 2025 14:06
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@q10 q10 force-pushed the export-D67920539 branch from ed1f69b to 9cc6db5 Compare January 21, 2025 22:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67920539

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b858408.

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
Summary:
Pull Request resolved: facebookresearch/FBGEMM#642

X-link: pytorch#3556

- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539

fbshipit-source-id: 3d421d00c61b1a6e85927ff1055aecad4819a4af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants