Fix handling of dynamic FP8 grouped gemm on Nvidia #3616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D68689077 |
jwfromm
force-pushed
the
export-D68689077
branch
from
a54320c to
57d9a8d
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
jwfromm
force-pushed
the
export-D68689077
branch
from
57d9a8d to
22b97a5
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
|
This pull request was exported from Phabricator. Differential Revision: D68689077 |
Summary: X-link: facebookresearch/FBGEMM#695 Pull Request resolved: pytorch#3616 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
|
This pull request was exported from Phabricator. Differential Revision: D68689077 |
jwfromm
force-pushed
the
export-D68689077
branch
from
22b97a5 to
5c2ec33
Compare
|
This pull request has been merged in ecb19d9. |
avbokovoy
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/695 Pull Request resolved: pytorch#3616 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077 fbshipit-source-id: f60b533e6ec90b753dc15f2136c7cef6e162bf1c
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#695 X-link: pytorch#3616 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077 fbshipit-source-id: f60b533e6ec90b753dc15f2136c7cef6e162bf1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward.
Differential Revision: D68689077