write_k_back for fp8 ROPE #3679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69182701 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: X-link: facebookresearch/FBGEMM#756 Needed for tree attention. Make rope write the xk for the suffix back to the input xk before applying quantization. Reviewed By: jianyuh Differential Revision: D69182701
Aya-ZIbra
force-pushed
the
export-D69182701
branch
from
8cea48e to
3895ba4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69182701 |
|
This pull request has been merged in 4259eb4. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3679 Pull Request resolved: facebookresearch/FBGEMM#756 Needed for tree attention. Make rope write the xk for the suffix back to the input xk before applying quantization. Reviewed By: jianyuh Differential Revision: D69182701 fbshipit-source-id: ba279706f4807d66fc1738796ea9e433705b285d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/756
Needed for tree attention. Make rope write the xk for the suffix back to the input xk before applying quantization.
Reviewed By: jianyuh
Differential Revision: D69182701