adding an option to skip zeroing output tensor for f8f8bf16_rowwise_grouped_dynamic #3685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69380351 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mxz297
force-pushed
the
export-D69380351
branch
from
77d375a to
c06ae8e
Compare
mxz297
added a commit
to mxz297/FBGEMM
that referenced
this pull request
Feb 15, 2025
…rouped_dynamic (pytorch#3685) Summary: X-link: facebookresearch/FBGEMM#761 In certain uses cases, the user of this api does not need zeroing out the padded area, so add this option. Note that currently the actual skipping is only done for AMD. Differential Revision: D69380351
|
This pull request was exported from Phabricator. Differential Revision: D69380351 |
mxz297
added a commit
to mxz297/FBGEMM
that referenced
this pull request
Feb 15, 2025
…rouped_dynamic (pytorch#3685) Summary: X-link: facebookresearch/FBGEMM#761 In certain uses cases, the user of this api does not need zeroing out the padded area, so add this option. Note that currently the actual skipping is only done for AMD. Differential Revision: D69380351
mxz297
force-pushed
the
export-D69380351
branch
from
c06ae8e to
e883746
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69380351 |
…rouped_dynamic (pytorch#3685) Summary: X-link: facebookresearch/FBGEMM#761 In certain uses cases, the user of this api does not need zeroing out the padded area, so add this option. Note that currently the actual skipping is only done for AMD. Differential Revision: D69380351
mxz297
force-pushed
the
export-D69380351
branch
from
e883746 to
b4e8bd8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69380351 |
|
This pull request has been merged in f8f6f43. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
…rouped_dynamic (pytorch#761) Summary: X-link: pytorch#3685 Pull Request resolved: facebookresearch/FBGEMM#761 In certain uses cases, the user of this api does not need zeroing out the padded area, so add this option. Note that currently the actual skipping is only done for AMD. Reviewed By: jwfromm Differential Revision: D69380351 fbshipit-source-id: 1e4eb901bd665f9446e5e9946bb659f787698758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In certain uses cases, the user of this api does not need zeroing out the padded area, so add this option. Note that currently the actual skipping is only done for AMD.
Differential Revision: D69380351