Implement generate_vbe_metadata cpu #3715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spcyppt
force-pushed
the
export-D69162870
branch
from
7529dfe to
b2d0bcd
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Feb 21, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Differential Revision: D69162870
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
force-pushed
the
export-D69162870
branch
from
b2d0bcd to
aac9690
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Differential Revision: D69162870
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
aac9690 to
ae43025
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Feb 26, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
ae43025 to
90727e6
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Feb 26, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
2 times, most recently
from
3a59542 to
104fc25
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 3, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap Differential Revision: D69162870
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
force-pushed
the
export-D69162870
branch
from
104fc25 to
ea6a843
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap Differential Revision: D69162870
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
force-pushed
the
export-D69162870
branch
from
ea6a843 to
5ab0b9b
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap Differential Revision: D69162870
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
5ab0b9b to
bb38a62
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
f990938 to
cd6d50b
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
cd6d50b to
791a482
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
791a482 to
7adeb1c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
7adeb1c to
be33b5b
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
be33b5b to
4b55c11
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
4b55c11 to
9222538
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
force-pushed
the
export-D69162870
branch
from
9222538 to
0f37ada
Compare
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
|
This pull request was exported from Phabricator. Differential Revision: D69162870 |
spcyppt
force-pushed
the
export-D69162870
branch
from
0f37ada to
3892615
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 5, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 5, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 5, 2025
Summary: X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: pytorch#3715 X-link: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870
|
This pull request has been merged in f0ff8bb. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3715 Pull Request resolved: facebookresearch/FBGEMM#796 This diff implements `generate_vbe_metadata` for cpu, such that the function returns the same output for CPU, CUDA and MTIA. To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++. Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations. VBE CPU tests are in the next diff. Reviewed By: sryap, nautsimon Differential Revision: D69162870 fbshipit-source-id: 08c6e45b8f0d319b96371acaba0d9a27570a1bd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/796
This diff implements
generate_vbe_metadatafor cpu, such that the function returns the same output for CPU, CUDA and MTIA.To support VBE on CPU with existing fixed-batch-size CPU kernel, we need to recompute offsets, which is previously done in python. This diff implements offsets recomputation in C++ such that all manipulations are done in C++.
Note that reshaping offsets and grad_input to work with existing fixed-batch-size CPU kernels are done in Autograd instead of wrapper to avoid multiple computations.
VBE CPU tests are in the next diff.
Reviewed By: sryap
Differential Revision: D69162870