Add custom reduce scatter to llama_comms #3730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In MOE, we have a pattern of allreduce -> split -> alltoall: https://fburl.com/gdoc/c2x38qxo. Add custom reduce scatter to simplilfy allreduce -> split path. Reviewed By: feikou Differential Revision: D69444988
|
This pull request was exported from Phabricator. Differential Revision: D69444988 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 4d81e47. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3730 Pull Request resolved: facebookresearch/FBGEMM#813 In MOE, we have a pattern of allreduce -> split -> alltoall: https://fburl.com/gdoc/c2x38qxo. Add custom reduce scatter to simplilfy allreduce -> split path. Reviewed By: feikou Differential Revision: D69444988 fbshipit-source-id: c86ebe61b767a45ccc0a3181ad4cf29182995ddf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In MOE, we have a pattern of allreduce -> split -> alltoall: https://fburl.com/gdoc/c2x38qxo. Add custom reduce scatter to simplilfy allreduce -> split path.
Reviewed By: feikou
Differential Revision: D69444988