Skip to content

[fbgemm_gpu] Limit the number of ROCm hardware targets #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[fbgemm_gpu] Limit the number of ROCm hardware targets #3797

wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Mar 11, 2025

  • Limit the number of ROCm hardware targets to reduce Nova ROCm build times

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 11, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 480671d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67d0b3492d315e00085f676e
😎 Deploy Preview https://deploy-preview-3797--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/limit-rocm-build-targets branch from e3500a4 to 6b72e32 Compare March 11, 2025 07:47
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/limit-rocm-build-targets branch 3 times, most recently from 12105bd to 447e5f4 Compare March 11, 2025 18:04
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/limit-rocm-build-targets branch from 447e5f4 to 223c0b6 Compare March 11, 2025 18:12
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

4 similar comments
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/limit-rocm-build-targets branch from 223c0b6 to 68d22ee Compare March 11, 2025 20:47
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/limit-rocm-build-targets branch from 68d22ee to f4db897 Compare March 11, 2025 22:02
@q10
[fbgemm_gpu] Limit the number of ROCm hardware targets
480671d 
- Limit the number of ROCm hardware targets to reduce Nova ROCm build times
@q10 q10 force-pushed the bm/limit-rocm-build-targets branch from f4db897 to 480671d Compare March 11, 2025 22:03
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in 944dff0.

liligwu pushed a commit to ROCm/FBGEMM that referenced this pull request Mar 14, 2025
@q10 @liligwu
Limit the number of ROCm hardware targets (pytorch#3797)
c7f7f5a 
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/886

- Limit the number of ROCm hardware targets to reduce Nova ROCm build times

Pull Request resolved: pytorch#3797

Reviewed By: sryap

Differential Revision: D70949678

Pulled By: q10

fbshipit-source-id: a14cc0f12c7988aa3e9b68549bad9d109f1d7ca6
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
@q10 @facebook-github-bot
Limit the number of ROCm hardware targets (pytorch#886)
e754b2d 
Summary:
Pull Request resolved: facebookresearch/FBGEMM#886

- Limit the number of ROCm hardware targets to reduce Nova ROCm build times

X-link: pytorch#3797

Reviewed By: sryap

Differential Revision: D70949678

Pulled By: q10

fbshipit-source-id: a14cc0f12c7988aa3e9b68549bad9d109f1d7ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category:improvement ciflow/rocm cla signed feature:builds Merged module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot