Reduce bulk init time and fix OOM #3828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D70921864 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peterfu0
added a commit
to peterfu0/FBGEMM-1
that referenced
this pull request
Mar 15, 2025
Summary: X-link: facebookresearch/FBGEMM#911 X-link: facebookresearch/FBGEMM#909 X-link: facebookresearch/FBGEMM#908 Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue. Differential Revision: D70921864
peterfu0
force-pushed
the
export-D70921864
branch
from
c2073a0 to
6e3e8f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70921864 |
peterfu0
changed the title
peterfu0
force-pushed
the
export-D70921864
branch
from
6e3e8f0 to
815c500
Compare
peterfu0
added a commit
to peterfu0/FBGEMM-1
that referenced
this pull request
Mar 17, 2025
Summary: X-link: facebookresearch/FBGEMM#911 X-link: facebookresearch/FBGEMM#909 X-link: facebookresearch/FBGEMM#908 Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue. Differential Revision: D70921864
|
This pull request was exported from Phabricator. Differential Revision: D70921864 |
Summary: X-link: facebookresearch/FBGEMM#911 X-link: facebookresearch/FBGEMM#909 X-link: facebookresearch/FBGEMM#908 Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue. Differential Revision: D70921864
peterfu0
force-pushed
the
export-D70921864
branch
from
815c500 to
a637c89
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70921864 |
|
This pull request has been merged in 63e378a. |
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: pytorch#3828 X-link: https://github.com/facebookresearch/FBGEMM/pull/911 Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue. Reviewed By: duduyi2013 Differential Revision: D70921864 fbshipit-source-id: bb3c5103761a8f641d4ed8be93757902fcef91e0
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3828 Pull Request resolved: facebookresearch/FBGEMM#911 Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue. Reviewed By: duduyi2013 Differential Revision: D70921864 fbshipit-source-id: bb3c5103761a8f641d4ed8be93757902fcef91e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/911
Disable compaction when bulk initialize TBE in SSD, this reduce the initialization time from over 5mins to 2-3 mins. Also use bytes as the chunk size rather than row count, as each row might have different dimensions in different TBE, to avoid OOM issue.
Differential Revision: D70921864