Allow FBGEMM_TBE_BOUNDS_CHECK_MODE to take effect when using mode 4,5,6 #3838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D71344486 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yuhuishi-convect
force-pushed
the
export-D71344486
branch
from
30f6a86 to
40c826d
Compare
yuhuishi-convect
added a commit
to yuhuishi-convect/FBGEMM
that referenced
this pull request
Mar 18, 2025
…,6 (pytorch#3838) Summary: X-link: facebookresearch/FBGEMM#925 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: sryap Differential Revision: D71344486
yuhuishi-convect
force-pushed
the
export-D71344486
branch
from
40c826d to
d65498f
Compare
yuhuishi-convect
added a commit
to yuhuishi-convect/FBGEMM
that referenced
this pull request
Mar 18, 2025
…,6 (pytorch#3838) Summary: X-link: facebookresearch/FBGEMM#925 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: sryap Differential Revision: D71344486
|
This pull request was exported from Phabricator. Differential Revision: D71344486 |
yuhuishi-convect
added a commit
to yuhuishi-convect/FBGEMM
that referenced
this pull request
Mar 18, 2025
…,6 (pytorch#3838) Summary: X-link: facebookresearch/FBGEMM#925 Pull Request resolved: pytorch#3838 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: sryap Differential Revision: D71344486
yuhuishi-convect
force-pushed
the
export-D71344486
branch
from
d65498f to
dc6065b
Compare
…,6 (pytorch#3838) Summary: X-link: facebookresearch/FBGEMM#925 Pull Request resolved: pytorch#3838 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: sryap Differential Revision: D71344486
|
This pull request was exported from Phabricator. Differential Revision: D71344486 |
yuhuishi-convect
force-pushed
the
export-D71344486
branch
from
dc6065b to
6e46b19
Compare
|
This pull request has been merged in d3fd468. |
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Mar 19, 2025
…,6 (pytorch#3838) Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/925 Pull Request resolved: pytorch#3838 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: q10, sryap Differential Revision: D71344486 fbshipit-source-id: 17985d0176aef96641933c16ef33484c1cf6afb6
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
…,6 (pytorch#925) Summary: Pull Request resolved: facebookresearch/FBGEMM#925 X-link: pytorch#3838 This diff allows to set V2 check bound mode via env var `FBGEMM_TBE_BOUNDS_CHECK_MODE`, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL) Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2. Reviewed By: q10, sryap Differential Revision: D71344486 fbshipit-source-id: 17985d0176aef96641933c16ef33484c1cf6afb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff allows to set V2 check bound mode via env var
FBGEMM_TBE_BOUNDS_CHECK_MODE, by setting its value to 4 (V2_IGNORE), 5 (V2_WARNING), 6 (V2_FATAL)Previously, we can only get v2 check bound mode if bounds_check_mode is set to mode prefixed with V2.
Differential Revision: D71344486