A hotfix for FBGEMM fp8 rowwise with irregular gemm sizes #3883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Hotfix for T219165899 reported by pranavsh, which is caused by some instances requiring K size being multiple of `KTile` - Added fallback for GEMM cases with K is not multiple of Max KTile = 256. Reviewed By: jianyuh Differential Revision: D71863248
|
This pull request was exported from Phabricator. Differential Revision: D71863248 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 0ee4923. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3883 Pull Request resolved: facebookresearch/FBGEMM#974 - Hotfix for T219165899 reported by pranavsh, which is caused by some instances requiring K size being multiple of `KTile` - Added fallback for GEMM cases with K is not multiple of Max KTile = 256. Reviewed By: jianyuh Differential Revision: D71863248 fbshipit-source-id: ad70c413ffb9916627ed87d3f161f8bbfce328af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
KTileReviewed By: jianyuh
Differential Revision: D71863248