Skip to content

Modernize bf16 cutlass grouped gemm #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Mar 27, 2025

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 07feea3
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67e6e8aa2306ef00089e2a8c
😎 Deploy Preview https://deploy-preview-3889--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm added a commit to jwfromm/FBGEMM that referenced this pull request Mar 27, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64, mxz297

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm pushed a commit to jwfromm/FBGEMM that referenced this pull request Mar 28, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm pushed a commit to jwfromm/FBGEMM that referenced this pull request Mar 28, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

jwfromm pushed a commit to jwfromm/FBGEMM that referenced this pull request Mar 28, 2025
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64

Differential Revision: D71920813
Summary:
Pull Request resolved: pytorch#3889

X-link: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64

Differential Revision: D71920813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71920813

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5e684ba.

q10 pushed a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
Summary:
X-link: pytorch#3889

Pull Request resolved: facebookresearch/FBGEMM#982

This diff unifies the API between FP8 and BF16 grouped gemm. Specifically we add the same dynamic, concatenated, and stacked APIs that are used for FP8 across both cutlass and CK. After this change, our tests can also be unified into a single grouped gemm test that covers all the various modes.

Reviewed By: jiawenliu64

Differential Revision: D71920813

fbshipit-source-id: 4928c4299d2b62e1722faf8b2bc1ba278adf23a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants