Use Int64 Indexing in Grouped Gemm #3930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For very large sequence length workloads, its possible for int32 arithmetic to overflow, especially as we often use M*N size tensors in grouped gemm. This diff replaces int32 indexing with int64 to avoid this problem. Differential Revision: D72465728
|
This pull request was exported from Phabricator. Differential Revision: D72465728 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in f8322d7. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#1016 X-link: pytorch#3930 For very large sequence length workloads, its possible for int32 arithmetic to overflow, especially as we often use M*N size tensors in grouped gemm. This diff replaces int32 indexing with int64 to avoid this problem. Reviewed By: jianyuh Differential Revision: D72465728 fbshipit-source-id: 7af0d0c10f9e43029d26d1c674952ca51d4733b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For very large sequence length workloads, its possible for int32 arithmetic to overflow, especially as we often use M*N size tensors in grouped gemm. This diff replaces int32 indexing with int64 to avoid this problem.
Differential Revision: D72465728