Implement a separate kernel for array-based index remapping lookup. #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D30556183 |
…ytorch#682) Summary: Pull Request resolved: pytorch#682 This diff: * implements an array-based lookup kernel for embedding index remapping and makes it default; * adds a new benchmark for array-based pruning lookup; * adds new features into the nbit-device benchmark to run multiple iterations and ignore the warmup runs; Reviewed By: ajtulloch Differential Revision: D30556183 fbshipit-source-id: 58be36cab7076a2a62905c4181b6234a1dbf47b7
|
This pull request was exported from Phabricator. Differential Revision: D30556183 |
ipiszy
force-pushed
the
export-D30556183
branch
from
df28409 to
2a860b0
Compare
|
This pull request has been merged in 820b4c7. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3601 Pull Request resolved: facebookresearch/FBGEMM#682 Fix type to assert group size Reviewed By: jianyuh Differential Revision: D68499555 fbshipit-source-id: 58ac6869189924610d03ae7339ca3d24b1898fed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff:
Differential Revision: D30556183