Skip to content

Add capability to pass additional grad_kwargs for LayerGradientXActivation #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yucu
Copy link
Contributor

@yucu yucu commented May 24, 2024

Differential Revision: D57756842

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

@yucu yucu force-pushed the export-D57756842 branch from 75a4682 to 0f70668 Compare May 28, 2024 05:28
yucu added a commit to yucu/captum that referenced this pull request May 28, 2024
…ation (pytorch#1286)

Summary: Pull Request resolved: pytorch#1286

Differential Revision: D57756842
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

yucu added a commit to yucu/captum that referenced this pull request May 28, 2024
…ation (pytorch#1286)

Summary: Pull Request resolved: pytorch#1286

Differential Revision: D57756842
@yucu yucu force-pushed the export-D57756842 branch from 0f70668 to fe00106 Compare May 28, 2024 06:51
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

@yucu yucu force-pushed the export-D57756842 branch from fe00106 to 0226ea6 Compare May 28, 2024 07:35
yucu added a commit to yucu/captum that referenced this pull request May 28, 2024
…ation (pytorch#1286)

Summary: Pull Request resolved: pytorch#1286

Differential Revision: D57756842
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

@yucu yucu force-pushed the export-D57756842 branch from 0226ea6 to d5b99d2 Compare May 28, 2024 21:47
yucu added a commit to yucu/captum that referenced this pull request May 28, 2024
…ation (pytorch#1286)

Summary: Pull Request resolved: pytorch#1286

Differential Revision: D57756842
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

yucu added a commit to yucu/captum that referenced this pull request May 30, 2024
…ation (pytorch#1286)

Summary: Pull Request resolved: pytorch#1286

Differential Revision: D57756842
@yucu yucu force-pushed the export-D57756842 branch from d5b99d2 to 3115f85 Compare May 30, 2024 02:52
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

yucu added a commit to yucu/captum that referenced this pull request May 30, 2024
…ation (pytorch#1286)

Summary:

`torch.autograd.grad` can take several additional arguments like `retain_graph`, `create_graph`, `allow_unused` and `materialize_grads`. This change enable users of `LayerGradientXActivation` and `compute_layer_gradients_and_eval` to pass in those arguments if they want to.

Differential Revision: D57756842
@yucu yucu force-pushed the export-D57756842 branch from 3115f85 to 4c696f5 Compare May 30, 2024 16:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

…ation (pytorch#1286)

Summary:

`torch.autograd.grad` can take several additional arguments like `retain_graph`, `create_graph`, `allow_unused` and `materialize_grads`. This change enable users of `LayerGradientXActivation` and `compute_layer_gradients_and_eval` to pass in those arguments if they want to.

This change should solve issue on

Differential Revision: D57756842
@yucu yucu force-pushed the export-D57756842 branch from 4c696f5 to f597e2e Compare May 30, 2024 17:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57756842

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 03340ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants