-
Notifications
You must be signed in to change notification settings - Fork 647
Add low_cpu_ram config to qlora recipes configs (excluding 2B/13B/70B configs) #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1580
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 38b274d with merge base ee343e6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 73.08% 71.05% -2.03%
==========================================
Files 289 289
Lines 14157 14170 +13
==========================================
- Hits 10346 10068 -278
- Misses 3811 4102 +291 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay in getting to this one. This looks great!
Context
What is the purpose of this PR? Is it to
Addresses this comment https://github.com/pytorch/torchtune/pull/1315/files#r1750554790
Changelog
What are the changes made in this PR?
Update all qlora recipes to have low_cpu_ram config option added in #1315
Test plan
colab notebook https://colab.research.google.com/drive/14fGovrKguuTh67T0eL_rIg7gmJVaYSie?usp=sharing that tests checkpoint save with and without low_cpu_ram and verifies that with
low_cpu_ram=True
all of the qlora recipes updated here no longer OOM on checkpoint save.Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring:
torchtune/torchtune/modules/vision_transformer.py
Line 285 in 6a7951f
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models