Skip to content

fix missing key #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix missing key #1952

merged 1 commit into from
Nov 6, 2024

Conversation

felipemello1
Copy link
Contributor

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

"None" was missing in a couple of places.

without it:
image

with it:
image

tune run lora_finetune_single_device --config llama3/8B_dora_single_device \
optimizer_in_bwd=True \
enable_activation_checkpointing=True \
enable_activation_offloading=True \
gradient_accumulation_steps=1 \
compile=True \
dataset.packed=True \
dataset.split=train[:10%] \
tokenizer.max_seq_len=2048 \
metric_logger=torchtune.training.metric_logging.WandBLogger \
metric_logger.project=profiling \
metric_logger.tags=[my_experiment_name] \
log_every_n_steps=1 \
log_peak_memory_stats=True \
max_steps_per_epoch=15 \
epochs=2 \
batch_size=6 \
metric_logger.name=Dora_Save_adapter_weights_only \
save_adapter_weights_only=True

Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1952

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c38a46d with merge base 24d3579 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@felipemello1 felipemello1 merged commit 3f15030 into pytorch:main Nov 6, 2024
17 checks passed
joecummings pushed a commit that referenced this pull request Nov 11, 2024
Co-authored-by: Felipe Mello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants