-
Notifications
You must be signed in to change notification settings - Fork 647
Create _export directory in torchtune #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2011
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit af1bfc1 with merge base bd89bb8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D65982921 |
This pull request was exported from Phabricator. Differential Revision: D65982921 |
Summary: Creates a placeholder directory for adding exportable torchtune components Reviewed By: larryliu0820, dvorjackz Differential Revision: D65982921
0733fa5
to
af1bfc1
Compare
This pull request was exported from Phabricator. Differential Revision: D65982921 |
If this has been already discussed with other members of the team I apologize, but what's the context here? Why do exportable components need to live in torchtune? |
Hey @Jack-Khuu and @dvorjackz, just caught up on the context of this change. Would be awesome if you could detail in the PR summary the motivation for this folder (clean dependency graph for torchchat and executorch for exportable modules) and what the plan is for CI. From what I gathered, the CI will live in torchtune and code quality/updating the CI for One concern I have is if an unrelated change in torchtune breaks exportability CI, is it our responsibility to fix this? Is there any way to separate exportability CI from our core CI? |
Thanks for checking in, we've been talking with @ebsmothers and the design is in the internal Diff comments, so that it doesn't pop up in OSS. I can add an abridged version to the PR as well
Correct, PyTorch Edge will own and update the code and CI for these modules. If tune has changes that breaks exportability, Edge will champion the fix (the CI for this will be non-blocking for torchtune) |
Cool, thanks for the additional context. I can stamp this once the PR summary is updated. |
Added some more detail @RdoubleA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for weighing in here. Discussed with most folks in this thread offline already so I think we should be good to go on this PR
Summary: Creates a placeholder directory for adding exportable torchtune components
PyTorch Edge and ExecuTorch have been working with torchtune folk to create exportable variants of torchtune modules these past few months. The variants will be used to demonstrate new inference modes via torchtune components in the near future
This new directory will serve to host these components and will be leveraged in other repos, such as ExecuTorch and torchchat. These components are NOT meant for use during fine-tuning
Note that this PR only creates the
_export
directory to allow parallel contributions with minimal merge conflict.Reviewed By: larryliu0820
Differential Revision: D65982921