Update DPO Max Seq Len #2176
Merged
Update DPO Max Seq Len #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2176
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d04db5c with merge base 3518492 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
felipemello1
approved these changes
Dec 18, 2024
joecummings
reviewed
Dec 19, 2024
| @@ -31,7 +31,7 @@ model: | |||
| tokenizer: | |||
| _component_: torchtune.models.llama3.llama3_tokenizer | |||
| path: /tmp/Meta-Llama-3.1-8B-Instruct/original/tokenizer.model | |||
| max_seq_len: null | |||
There was a problem hiding this comment.
Shouldn't this be like 8K? B/c the default dataset has an average seq len > 7K
felipemello1
pushed a commit
that referenced
this pull request
Dec 20, 2024
mori360
pushed a commit
to mori360/torchtune
that referenced
this pull request
Dec 20, 2024
rahul-sarvam
pushed a commit
to sarvamai/torchtune
that referenced
this pull request
Dec 23, 2024
rahul-sarvam
pushed a commit
to sarvamai/torchtune
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Default value for 8.1 updated to match llama2. Without truncating the datasets long sequences cause OOM.
Changelog
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testtune run lora_dpo_single_device --config llama3_1/8B_lora_dpo_single_devicetune run --nproc_per_node 2 lora_dpo_distributed --config llama3_1/8B_lora_dpo