Skip to content

[ez] Add output_dir field to a couple configs #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

ebsmothers
Copy link
Contributor

This field was still missing from a couple configs (I think they were inflight when #2183 landed).

Test plan:

tune run eleuther_eval --config llama3_2/evaluation
...
Running loglikelihood requests:  39%|████████████████████████████████████████████▍                                                                                                      | 2313/5882 [10:34<16:10,  3.68it/s]

Copy link

pytorch-bot bot commented Jan 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2309

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41243cc with merge base 90fd2d3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025
@RdoubleA RdoubleA merged commit d4465c8 into pytorch:main Jan 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants