Test alignment of shared methods in recipes #2807
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
While reviewing recipes, I’ve noticed that sometimes modifications made to “shared” methods in one recipe aren’t reflected in another.
For instance, consider the full fine-tune and LoRA fine-tune recipes.
These recipes should only differ in the way a model is instantiated and a checkpoint is saved. All other methods should be identical to the line. However, this isn’t the case.
As discussed in #2779, one potential solution is to implement a test that parses these methods and checks for equality.
This approach offers several benefits:
The proposed test can:
Important
This draft covers only full fine-tune and LoRA variants.
If the core team decides that this is the way to go - I'll extend it to all recipes.