Fix CPU tests for python 3.12 #9443
Open
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanyong-wan
reviewed
Jul 8, 2025
| @@ -68,7 +68,6 @@ | |||
| platform_machine = platform.machine() | |||
|
|
|||
| base_dir = os.path.dirname(os.path.abspath(__file__)) | |||
|
|
|||
| @@ -123,7 +123,7 @@ function run_torch_op_tests { | |||
| run_test_without_functionalization "$_TEST_DIR/../../test/test_view_ops.py" "$@" -v TestViewOpsXLA | |||
| run_test "$_TEST_DIR/../../test/test_torch.py" "$@" -v TestTorchDeviceTypeXLA | |||
| run_dynamic "$_TEST_DIR/../../test/test_torch.py" "$@" -v TestDevicePrecisionXLA | |||
| run_test "$_TEST_DIR/../../test/test_torch.py" "$@" -v TestTensorDeviceOpsXLA | |||
| # run_test "$_TEST_DIR/../../test/test_torch.py" "$@" -v TestTensorDeviceOpsXLA | |||
There was a problem hiding this comment.
Why's this commented out?
| XLAGraphExecutor::Get()->GetLiveTensors(&backend_device); | ||
| } else { | ||
| xtensors = GetXlaTensors(tensors, /*want_all=*/false); | ||
| bool emit_bytecode) { |
There was a problem hiding this comment.
I don't understand why we should remove the py::bytes return type. The PR description says it's undefined behavior - how?
| } | ||
| return py::bytes( | ||
| XLAGraphExecutor::Get()->DumpHloComputation(xtensors, mode)); |
There was a problem hiding this comment.
Is the old behavior a bug? How was the bug introduced without being noticed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py::bytesout of NoGil section as it is undefined behavior and causes segfaultTestTensorDeviceOpsXLAas it doesn't run any tests and causes the whole test suite to fail