Mrtd overflow fixes #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing buffer sized to 300 to allow reading of tags with more data. One instance of this is a the EF.COM page for a US passport. In the future this should be probably be a dynamically allocated buffer via malloc or other heap allocation.
17 tasks
|
Are the changes to the submodules required for this fix? Also, can we fix compile problems showing up with un-initialized date variable? I'm not really sure how the particular variable should get initialized so hoping you can help @qistoph ... |
Author
|
@RogueMaster Gah I really hate submodules.. yeah the submodule changes aren't needed. Is it possible to add .gitmodules to the .gitignore? :) |
|
I fixed compile issue I was getting... to revert the submodules you can git checkout in the submodule folder |
For data that is over 256 bytes this overflows till the board crashes when it hits an invalid address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)