Skip to content

Adds a multi-processing simulator for the xmon native gates. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Adds a multi-processing simulator for the xmon native gates. #1

merged 1 commit into from
Jan 9, 2018

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jan 9, 2018

No description provided.

@dabacon dabacon requested a review from Strilanc January 9, 2018 05:17
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.from __future__ import absolute_import
Copy link
Contributor

@Strilanc Strilanc Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"limitations under the License.from __future__ import absolute_import"? Looks like a search/replace error.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut and past error. Fixed.

Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff. Fix it then LGTM.


state = _state_shard(args)
normalization = np.sqrt(prob_one if result else 1 - prob_one)
state *= _one_projector(args, index) * result \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use parens for line continuation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dabacon
Copy link
Collaborator Author

dabacon commented Jan 9, 2018

Thanks.

@dabacon dabacon merged commit 24d54fa into quantumlib:master Jan 9, 2018
Strilanc added a commit that referenced this pull request Oct 2, 2018
- Change fallback representation from (gate:0, gate:1, ...) to (gate, #1, #2, ...)
- Fix qubit-symbol mismatch error saying the wrong number.
- Drop ext argument.
- Had to update contrib/qcircuit_diagram because it uses the ext argument.
- Fixed qcircuit_diagram not aligning its output to column boundaries. Looks much better now.
- Updaded GateOperation and ControlledGate to delegate to cirq.circuit_diagram_info
peterse added a commit to peterse/Cirq that referenced this pull request Jun 25, 2019
maffoo pushed a commit to maffoo/Cirq that referenced this pull request Oct 15, 2020
mrwojtek referenced this pull request in dstrain115/Cirq-1 Jan 20, 2021
1) Add PhasedFSimParameters container that describes cirq.PhasedFSimGate angles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants