Skip to content

Add support for deep=True to cirq.synchronize_terminal_measurements transformer #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Add support for deep=True to cirq.synchronize_terminal_measurements transformer #5118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd6d5d5
Add support for deep=True to cirq.synchronize_terminal_measurements t…
tanujkhattar Mar 21, 2022
99d35c9
Merge branch 'master' into synchronize_terminal_measurements_deep
CirqBot Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cirq-core/cirq/transformers/synchronize_terminal_measurements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def find_terminal_measurements(
return terminal_measurements


@transformer_api.transformer
@transformer_api.transformer(add_deep_support=True)
def synchronize_terminal_measurements(
circuit: 'cirq.AbstractCircuit',
*,
Expand Down
34 changes: 26 additions & 8 deletions cirq-core/cirq/transformers/synchronize_terminal_measurements_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,35 @@


def assert_optimizes(before, after, measure_only_moment=True, with_context=False):
transformed_circuit = (
cirq.synchronize_terminal_measurements(before, after_other_operations=measure_only_moment)
if not with_context
else cirq.synchronize_terminal_measurements(
before,
context=cirq.TransformerContext(tags_to_ignore=(NO_COMPILE_TAG,)),
after_other_operations=measure_only_moment,
)
context = cirq.TransformerContext(tags_to_ignore=(NO_COMPILE_TAG,)) if with_context else None
transformed_circuit = cirq.synchronize_terminal_measurements(
before, context=context, after_other_operations=measure_only_moment
)
cirq.testing.assert_same_circuits(transformed_circuit, after)

# Test nested circuit ops.
context = cirq.TransformerContext(
tags_to_ignore=("ignore",) + tuple([NO_COMPILE_TAG] if with_context else []), deep=True
)
c_nested = cirq.Circuit(
before,
cirq.CircuitOperation(before.freeze()).repeat(5).with_tags("ignore"),
before,
cirq.CircuitOperation(before.freeze()).repeat(6).with_tags("preserve_tag"),
before,
)
c_expected = cirq.Circuit(
before,
cirq.CircuitOperation(before.freeze()).repeat(5).with_tags("ignore"),
before,
cirq.CircuitOperation(after.freeze()).repeat(6).with_tags("preserve_tag"),
after,
)
transformed_circuit = cirq.synchronize_terminal_measurements(
c_nested, context=context, after_other_operations=measure_only_moment
)
cirq.testing.assert_same_circuits(transformed_circuit, c_expected)


def test_no_move():
q1 = cirq.NamedQubit('q1')
Expand Down