-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add async support in EngineClient, EngineSampler, etc. #5219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d0e9c16
wip - Add async support in EngineSampler
maffoo 4c36675
wip - xfail tests that use AsyncMock in python < 3.8
maffoo 62babd3
Instantiate AsyncioExecutor lazily
maffoo 4ef9591
Merge branch 'master' into u/maffoo/engine-async
maffoo 90d3220
Merge branch 'master' into u/maffoo/engine-async
maffoo a6d7fff
Revert changes to engine_sampler.py and tests
maffoo 757437c
Remove unused import
maffoo 09e0eab
Add docstring for AsyncioExecutor
maffoo c0bbc68
Revert engine.py changes
maffoo 1ab5b83
Rename util_test.py -> test_utils.py
maffoo 7b8b35a
Merge branch 'master' into u/maffoo/engine-async
maffoo 8070f71
Merge branch 'master' into u/maffoo/engine-async
maffoo 4bee996
Revert change to engine_sampler_test
maffoo 4a6ea40
Merge branch 'master' into u/maffoo/engine-async
maffoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're moving towards encouraging people to use EngineProcessor.run methods instead of
Engine
becauseAbstractEngine
doesn't actually have any of these methods so they don't get mocked by the simulated versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted changes to the
run*
methods onEngine
.