-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update ops notebook #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ops notebook #5245
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about this table (which reviewnb totally barfs on)
docs/operators_and_observables.ipynb
Outdated
"| Measurements | `cirq.measure` and `cirq.MeasurementGate` | [Gates and operations](gates.ipynb) | `cirq.measure(cirq.LineQubit(0))` | \n", | ||
"| Quantum channels | <ul> <li>Kraus operators (any class implementing the `_kraus_` protocol)</li><li>Pauli basis (cirq.PauliSum)</li> </ul> | [Protocols](protocols.ipynb) | `cirq.DepolarizingChannel(p=0.2)(q0)` <br> `cirq.X.with_probability(0.5)`|" | ||
"| Quantum channels | <ul> <li>Kraus operators (any class implementing the `_kraus_` and `_has_kraus_` protocol)</li><li>Unitary mixtures (any class implementing the `_mixture_` and `_has_mixture_` protocol)</li><li>Pauli basis (cirq.PauliSum)</li> </ul> | [Protocols](protocols.ipynb) | `cirq.DepolarizingChannel(p=0.2)(q0)` <br> `cirq.X.with_probability(0.5)`|" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not your doing but how do you create a channel from a Pauli basis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. It was already there and I think the tutorial talks about PauliSum and expectations briefly which seemed OK to me. Do you think we should remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I don't see how it really makes sense here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Added new protocols to list of protocols as well as some minor cleanup.
Added new protocols to list of protocols as well as some minor cleanup.
Added new protocols to list of protocols as well as some minor cleanup.