Skip to content

Check that control and target qubits disjoint in ControlledOperations #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Apr 23, 2022

Adds check that control and target qubits are disjoint and that control qubits are unique, plus tests.

xref #4007

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners April 23, 2022 19:35
@daxfohl daxfohl requested a review from mpharrigan April 23, 2022 19:35
@CirqBot CirqBot added the size: S 10< lines changed <50 label Apr 23, 2022
@95-martin-orion 95-martin-orion merged commit 859a16d into quantumlib:master Apr 25, 2022
@daxfohl daxfohl deleted the controlled-circuitop branch April 26, 2022 14:17
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…quantumlib#5286)

* Check that control and target qubits don't overlap in ControlledOperations

* Add unique control qubits constraint

* reformat imports

* reformat imports
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…quantumlib#5286)

* Check that control and target qubits don't overlap in ControlledOperations

* Add unique control qubits constraint

* reformat imports

* reformat imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants