Rename create_act_on_args to create_simulation_state

[daxfohl]

@95-martin-orion Here's this allows safely deprecating those functions. Plus ProductSimulationState.args is now ProductSimulationState.sim_states, and also renamed the args param for public act_on protocol.

[95-martin-orion]

Couple of issues. I'm also kind of blindly assuming there aren't "args" appearances outside of the changes here - how did you go about checking for these?

[daxfohl]

There are definitely "args" appearances beyond these fixes. I don't have a good way of checking for all of them -- our other protocols like unitary also uses "args", not to mention it's a python keyword, so we can't just find/replace all.

However this PR does take care of all the regex 'act_on\w*_args' appearances at least, and I'm pretty sure it takes care of all appearances of "args" in public functions / properties. But there are still lots of places where local variables are just named "args", especially in tests. To completely kill them we probably have to skim through sim manually and replace whatever we find.

[95-martin-orion]

{...} this PR does take care of all the regex 'act_on\w*_args' appearances at least, and I'm pretty sure it takes care of all appearances of "args" in public functions / properties.

I think if we've hit these, that's enough to call this PR complete - we can catch the rest in code cleanup down the road.