create_device_from_processor_id #5303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested review from
wcourtney,
a team,
vtomole and
cduck
as code owners
verult
approved these changes
Apr 29, 2022
| @@ -206,6 +206,30 @@ def _create_device_spec_from_template(template_name: str) -> v2.device_pb2.Devic | |||
| return device_spec | |||
|
|
|||
|
|
|||
| def create_device_from_processor_id( | |||
| processor_id: str, | |||
| gate_sets: Optional[Iterable[serializable_gate_set.SerializableGateSet]] = None, | |||
There was a problem hiding this comment.
I recommend omitting this arg and always set the gateset to FSIM_GATESET. The new Device implementation (cirq_google.GridDevice) will not have gatesets as a parameter to from_proto.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* get_device_from_processor_id * Remove py3.8 feature * FSIM_GATESET only * [FSIM_GATESET]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a convenience method for creating a device from a processor ID.
This is useful for creating virtual engines using non-Cirq simulators (like qsim), since we can't directly reference those simulators in cirq code. For example: