Add native gates for IonQ #5313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When circuits are submit, autodetect if only native gates are included, in which case the lang selection changes to 'native'. This also changes the default from 'json' to 'qis' (a newer alias of the same language). For now, it is not possible to compile to the native gates, but in a future change, we are hoping to add a CompilationTargetGatset for our native gates.
Cynocracy
requested review from
dabacon,
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole and
cduck
as code owners
|
Is there any big reason to worry about skipping serialization, maybe TFQ and other library interop for these gates? |
|
Gonna do the json bits :) Am worried I'd be missing something otherwise |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Add native gates for IonQ When circuits are submit, autodetect if only native gates are included, in which case the lang selection changes to 'native'. This also changes the default from 'json' to 'qis' (a newer alias of the same language). For now, it is not possible to compile to the native gates, but in a future change, we are hoping to add a CompilationTargetGatset for our native gates. * fmt * Lint happy * Expose gates * Satisfy mypy * Fmt * Hack around laziness re: json format * Appease coverage * fmt * Support JSON * Fmt and fix Repr * huh? * Confusing json :/ * Confusing json take 2 * Confusing json take 3\? * Figure out the missing magic, implement * Lang -> Gateset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When circuits are submit, autodetect if only native gates are included, in which case the lang selection changes to 'native'.
This also changes the default from 'json' to 'qis' (a newer alias of the same language).
For now, it is not possible to compile to the native gates, but in a future change, we are hoping to add a CompilationTargetGatset for our
native gates.
I'm stepping on my own feet a bit with #5127 but overall I'm pretty comfortable with the way autodetection of native-only works here. If a user tries to mix and match QIS and Native gates, they will get an error from the IonQ backend. In the future, I would like there to be two CompilationTargetGatesets for IonQ, the existing one and one that targets these new gates.