Skip to content

Remove ids from notebooks #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022
Merged

Remove ids from notebooks #5325

merged 2 commits into from
May 3, 2022

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented May 3, 2022

These appear to have come from a jupyter nbformat versioning issue. "id" was added in the 4.5 schema. Somehow these got saved into a 4.0 schema notebook.

This breaks our nightly docs build right now.

@dabacon dabacon requested review from a team, vtomole and cduck as code owners May 3, 2022 21:10
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dabacon dabacon requested review from maffoo and wcourtney and removed request for maffoo May 3, 2022 21:10
@CirqBot CirqBot added the size: S 10< lines changed <50 label May 3, 2022
@95-martin-orion 95-martin-orion merged commit 7f10da5 into quantumlib:master May 3, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Remove extra ids from gatezoo notebook

* Update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants