Create a MomentBuilder for faster building of circuits. #5331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually this may kind of be crap. Alternatively when building a circuit with EARLIEST strategy, we can have a specialized method that keeps a dictionary of qubits, mkeys, and ckeys to the last moment index that contains them. Then instead of having to start at the end and check each moment, you can look up the correct moment in constant time. That would probably be a bit faster than this in most cases, and way faster if you have a long circuit and are building it qubit-by-qubit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely hacky but short and effective way of speeding up large circuit creation by 30x. I'm open to ideas on how to make this less hacky before merging. Or maybe it's good enough.