Skip to content

IonQ: Include json body of error response when possible #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 6, 2022
Merged

IonQ: Include json body of error response when possible #5349

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2607f89
IonQ: Include json body of error when possible
Cynocracy May 11, 2022
223cae5
fmt
Cynocracy May 11, 2022
0b38615
Fixup catch
Cynocracy May 18, 2022
0324f03
Merge branch 'master' into log-error-message
Cynocracy May 18, 2022
97c013b
import order
Cynocracy May 18, 2022
3894741
Merge branch 'log-error-message' of github.com:Cynocracy/Cirq into lo…
Cynocracy May 18, 2022
90fd350
coverage ignore
Cynocracy May 18, 2022
6e6166f
fmt
Cynocracy May 18, 2022
e97faeb
Merge branch 'master' into log-error-message
Cynocracy May 18, 2022
4fe104a
More cov ignore
Cynocracy May 18, 2022
d6612df
Merge branch 'log-error-message' of github.com:Cynocracy/Cirq into lo…
Cynocracy May 18, 2022
7e1cd7a
Merge branch 'master' into log-error-message
Cynocracy May 24, 2022
a2ecc42
Merge branch 'master' into log-error-message
dabacon Jun 6, 2022
ab1dfac
Merge branch 'master' into log-error-message
CirqBot Jun 6, 2022
3647e69
Merge branch 'master' into log-error-message
CirqBot Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cirq-ionq/cirq_ionq/ionq_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,11 +301,17 @@ def _make_request(
'IonQ could not find requested resource.'
)
if not _is_retriable(response.status_code):
error = {}
try:
error = response.json()
except json.decoder.JSONDecodeError:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will reference json from the parameter. Probably best solution is to import json.decoder as jd or something like that and then us that reference here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, right! Thanks for catching

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this more, I probably shouldn't coverage ignore the except case if I already did a bug

pass # Ignore invalid/missing JSON.
raise ionq_exceptions.IonQException(
'Non-retry-able error making request to IonQ API. '
f'Request Body: {json} '
f'Response Body: {error} '
f'Status: {response.status_code} '
f'Error :{response.reason}',
f'Error:{response.reason}',
response.status_code,
)
message = response.reason
Expand Down