Fix type check of SerializableDevice gate_definitions #5447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type(cirq.Gate) is cirq.ABCMetaImplementAnyOneOf which could match unrelated instances. Use subclass check instead.
pavoljuhas
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
viathor
reviewed
Jun 5, 2022
These can be only of cirq.FrozenCircuit or cirq.Gate types; instances should not happen. Also turn off Gateset unroll_circuit_op flag when gate_definitions indicate device does not support subcircuits.
The keys of the gate_definitions argument can be one of (cirq.Gate, cirq.FrozenCircuit) types.
Avoid shadowing import of the serializer module.
Avoid importing module-private object from another module.
viathor
approved these changes
Jun 8, 2022
dstrain115
reviewed
Jun 9, 2022
Keys in the `gate_definitions` dictionary should be ignored if not of the cirq.Gate or derived type.
…typo-in-type-check
Test added to the master with 62926b8 where it fails, because argument filter keeps NoiseModel type. The test passes after merging to this PR - 2b12d1a. |
|
@dstrain115 - perhaps this is ready for the automerge flag? |
dstrain115
approved these changes
Jun 16, 2022
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
The type(cirq.Gate) is cirq.ABCMetaImplementAnyOneOf which could match unrelated instances. Use subclass check instead and remove `isinstance()` check which should never happen. Clarify typing of the `gate_definitions` dictionary keys in SeriazableDevice. Finally, turn off Gateset unroll_circuit_op flag when gate_definitions indicate device does not support subcircuits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type(cirq.Gate) is cirq.ABCMetaImplementAnyOneOf which could
match unrelated instances. Use subclass check instead and remove
isinstance()check which should never happen.Clarify typing of the
gate_definitionsdictionary keys in SeriazableDevice.Finally, turn off Gateset unroll_circuit_op flag when gate_definitions indicate
device does not support subcircuits.