-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rabi content has been moved to ReCirq: Delete the items in Cirq #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also update the intro notebook to not use now-moved recirq experiment Also ran a formatter and cleared outputs from intro notebook
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
LGTM, there are some conflict with #5409 most importantly probably the picture (picture is not Sycamore, it's Bristlecone!), so whichever gets merged first will need to reconcile. |
@@ -2,14 +2,14 @@ | |||
"cells": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #15. print("Before optimizing:\n{}\n".format(circuit))
slight pref for f-strings these days. Probably should at least be consistent across the notebook.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
I wish we hadn't removed this; it is a very useful "hello world" sort of experiment, which we use internally quite a bit and is nice for tutorials. |
Where is is it used internally, except for that intro page? Where would you like it to be used? My thought is that: A "hello world" level example shouldn't be so complicated that hiding away the circuit construction in a library call is necessary. If a function that generates a specific type of circuit is so widely useful, it may definitely be useful to bring it back in some form, perhaps in the same way as |
In this case circuit is not particularly complicated to construct; the nice thing about the experiment function is the result type which can be plotted without parsing sweep results and converting to probs, and the fact that the whole thing can be run as a one-liner after just importing The places where we use this internally are more like hardware hello world examples, that is, places where we're trying to demonstrate basic functioning of a real hardware device, rather than basics of cirq. We just want to take some actual data and plot it to see that it looks reasonable. I guess this is more like a hello world for |
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
Rabi Oscillations have been moved per quantumlib/ReCirq#292.
Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography)
Also ran a formatter and cleared outputs from intro notebook
Only merge with redirect cl/452988155