Skip to content

Rabi content has been moved to ReCirq: Delete the items in Cirq #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 14, 2022

Conversation

augustehirth
Copy link
Collaborator

@augustehirth augustehirth commented Jun 6, 2022

Rabi Oscillations have been moved per quantumlib/ReCirq#292.
Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography)
Also ran a formatter and cleared outputs from intro notebook

Only merge with redirect cl/452988155

Also update the intro notebook to not use now-moved recirq experiment
Also ran a formatter and cleared outputs from intro notebook
@augustehirth augustehirth requested review from a team, vtomole, cduck and mrwojtek as code owners June 6, 2022 15:32
@augustehirth augustehirth requested a review from tanujkhattar June 6, 2022 15:32
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: XL lines changed >1000 label Jun 6, 2022
@dabacon
Copy link
Collaborator

dabacon commented Jun 6, 2022

LGTM, there are some conflict with #5409 most importantly probably the picture (picture is not Sycamore, it's Bristlecone!), so whichever gets merged first will need to reconcile.

@@ -2,14 +2,14 @@
"cells": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #15.    print("Before optimizing:\n{}\n".format(circuit))

slight pref for f-strings these days. Probably should at least be consistent across the notebook.


Reply via ReviewNB

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to consider.

@augustehirth augustehirth requested a review from dabacon June 6, 2022 18:44
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustehirth augustehirth added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 14, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 14, 2022
@CirqBot CirqBot merged commit 7941a3e into quantumlib:master Jun 14, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 14, 2022
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 14, 2022
augustehirth added a commit to augustehirth/Cirq that referenced this pull request Jun 15, 2022
…tumlib#5448)

Rabi Oscillations have been moved per quantumlib/ReCirq#292.
Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography)
Also ran a formatter and cleared outputs from intro notebook

Only merge with redirect cl/452988155
@augustehirth augustehirth deleted the rabi_cleanup branch June 15, 2022 03:53
@maffoo
Copy link
Contributor

maffoo commented Jun 29, 2022

I wish we hadn't removed this; it is a very useful "hello world" sort of experiment, which we use internally quite a bit and is nice for tutorials.

@augustehirth
Copy link
Collaborator Author

Where is is it used internally, except for that intro page? Where would you like it to be used?

My thought is that: A "hello world" level example shouldn't be so complicated that hiding away the circuit construction in a library call is necessary. If a function that generates a specific type of circuit is so widely useful, it may definitely be useful to bring it back in some form, perhaps in the same way as cirq.qft.

@maffoo
Copy link
Contributor

maffoo commented Jun 29, 2022

In this case circuit is not particularly complicated to construct; the nice thing about the experiment function is the result type which can be plotted without parsing sweep results and converting to probs, and the fact that the whole thing can be run as a one-liner after just importing cirq, without needing to import sympy for symbols, matplotlib for plotting, etc.

The places where we use this internally are more like hardware hello world examples, that is, places where we're trying to demonstrate basic functioning of a real hardware device, rather than basics of cirq. We just want to take some actual data and plot it to see that it looks reasonable. I guess this is more like a hello world for cirq.experiments since rabi oscillations are one of the simplest things one can demonstrate on a quantum device (certainly simpler than the tomography experiments or xeb which are still here).

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…tumlib#5448)

Rabi Oscillations have been moved per quantumlib/ReCirq#292.
Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography)
Also ran a formatter and cleared outputs from intro notebook

Only merge with redirect cl/452988155
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…tumlib#5448)

Rabi Oscillations have been moved per quantumlib/ReCirq#292.
Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography)
Also ran a formatter and cleared outputs from intro notebook

Only merge with redirect cl/452988155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants